Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests in cmd/ in parallel #2361

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Run tests in cmd/ in parallel #2361

merged 1 commit into from
Aug 9, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 9, 2024 •
edited
Loading

Proposed changes

Doing #2089 in phases so there aren't too many changes at once

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner August 9, 2024 19:48
@github-actions github-actions bot added the tests Pull requests that update tests label Aug 9, 2024
@lucacome lucacome enabled auto-merge (squash) August 9, 2024 20:03
@lucacome lucacome merged commit 6289c6e into nginxinc:main Aug 9, 2024
37 checks passed
@lucacome lucacome deleted the tests/cmd-parallel branch August 9, 2024 20:32
@bjee19 bjee19 mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees

@lucacome lucacome

Labels
tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @sjberman @kate-osborn